-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add warning that sccache isn't caching any commands since version 0.13.4 #35777
Conversation
@swift-ci Please smoke test |
docs/HowToGuides/GettingStarted.md
Outdated
@@ -137,6 +137,7 @@ Double-check that running `pwd` prints a path ending with `swift`. | |||
```sh | |||
brew install cmake ninja sccache | |||
``` | |||
⚠️ Since version 0.13.4, `sccache` no longer caches compile commands issued by `build-script` because of [this](https://github.com/mozilla/sccache/pull/898) change and since `build-script` adds the `-arch x86_64` argument twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be version 0.2.14
instead of 0.13.4
? (Releases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course. Thanks for checking.
1df9993
to
0a76294
Compare
@swift-ci Please smoke test |
docs/HowToGuides/GettingStarted.md
Outdated
@@ -137,6 +137,7 @@ Double-check that running `pwd` prints a path ending with `swift`. | |||
```sh | |||
brew install cmake ninja sccache | |||
``` | |||
⚠️ Since version 0.2.14, `sccache` no longer caches compile commands issued by `build-script` because of [this](https://github.com/mozilla/sccache/pull/898) change and since `build-script` adds the `-arch x86_64` argument twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized, this is in the macOS section, but this problem almost certainly affects Linux too. It may make more sense to have this warning be displayed immediately at the beginning of Installing dependencies section. Say something like:
⚠️ Since version 0.2.14, `sccache` no longer caches compile commands issued by `build-script` because of [sccache PR 898](https://github.com/mozilla/sccache/pull/898), since `build-script` adds the `-arch x86_64` argument twice. The instructions below may install `sccache` 0.2.14 or newer. You may want to instead download and install an older release from their [Releases page](https://github.com/mozilla/sccache/releases) until this issue is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
0a76294
to
9874152
Compare
@swift-ci Please smoke test |
No description provided.